Change XPS to use find and place glyph.

Change XPS to use find and place glyph.

Testing:
The testing I did is non-standard. I just compared images using XPS viewer.
They all looked the same, but the XPS device is suffering from bit rot.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/bda26436faacf21ae2afd572aacd45eaa79fd0a6

[herb_g, 2015-11-23 18:37:35]

Description was changed from

==========
Change XPS to use find and place glyph.

Testing:
The testing I did is non-standard. I just compared images using XPS viewer.
They all looked the same, but the XPS device is suffering from bit rot.

BUG=skia:
==========

to

==========
Change XPS to use find and place glyph.

Testing:
The testing I did is non-standard. I just compared images using XPS viewer.
They all looked the same, but the XPS device is suffering from bit rot.

BUG=skia:
==========

[herb_g, 2015-11-23 18:37:35]

herb@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2015-11-23 20:10:34]

Mostly nits, most apply to both drawPosText as well as drawText.

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
File src/device/xps/SkXPSDevice.cpp (right):

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2129: 
nit: whitepace

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2138: // Advance width and offsets for glyphs
measured in hundredths of the font em size (XPS Spec 5.1.3).
nit: line length, something like

    // Advance width and offsets measured in hundredths of font em size (XPS
Spec 5.1.3).

should work.

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2141:
xpsGlyphs.setReserve(num_glyph_guess(paint.getTextEncoding(), static_cast<const
char*>(text), byteLen));
nit: line length

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2149: // SkDraw may have clipped out the glyphs,
so we need to check
No longer using SkDraw for this, so this comment isn't valid anymore. Indeed, it
doesn't look like this is doing any clipping of glyphs anymore? It's still
possible that we don't get any glyphs back though, so we should still do this
check. For the time being the simplest thing to do would be to just remove this
comment.

[herb_g, 2015-11-24 15:34:45]

PTAL

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
File src/device/xps/SkXPSDevice.cpp (right):

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2129: 
On 2015/11/23 20:10:34, bungeman1 wrote:
> nit: whitepace

Done.

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2138: // Advance width and offsets for glyphs
measured in hundredths of the font em size (XPS Spec 5.1.3).
On 2015/11/23 20:10:34, bungeman1 wrote:
> nit: line length, something like
> 
>     // Advance width and offsets measured in hundredths of font em size (XPS
> Spec 5.1.3).
> 
> should work.

Done.

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2141:
xpsGlyphs.setReserve(num_glyph_guess(paint.getTextEncoding(), static_cast<const
char*>(text), byteLen));
On 2015/11/23 20:10:34, bungeman1 wrote:
> nit: line length

Done.

https://codereview.chromium.org/1471043002/diff/20001/src/device/xps/SkXPSDev...
src/device/xps/SkXPSDevice.cpp:2149: // SkDraw may have clipped out the glyphs,
so we need to check
On 2015/11/23 20:10:34, bungeman1 wrote:
> No longer using SkDraw for this, so this comment isn't valid anymore. Indeed,
it
> doesn't look like this is doing any clipping of glyphs anymore? It's still
> possible that we don't get any glyphs back though, so we should still do this
> check. For the time being the simplest thing to do would be to just remove
this
> comment.

Done.

[herb_g, 2015-11-24 15:34:48]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-11-24 15:34:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471043002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471043002/40001

[commit-bot: I haz the power, 2015-11-24 15:34:53]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-24 21:34 UTC

[commit-bot: I haz the power, 2015-11-24 15:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 15:37:56]

Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[bungeman-skia, 2015-11-24 15:49:15]

Aside from the warning as error, lgtm.

[herb_g, 2015-11-24 16:23:46]

The CQ bit was checked by herb@google.com

[herb_g, 2015-11-24 16:23:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1471043002/#ps60001
(title: "fix warning")

[commit-bot: I haz the power, 2015-11-24 16:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471043002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471043002/60001

[commit-bot: I haz the power, 2015-11-24 16:37:06]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/bda26436faacf21ae2afd572aacd45eaa79fd0a6