Fix phantom windows for small windows when using --ash-enable-alternate-caption-button

Fix phantom windows for small windows when using --ash-enable-alternate-caption-button.

This CL:
- Uses smaller assets for drawing the phantom window. This decreases the minimum size that a phantom window can be drawn at and still look good (i.e. the left and right corner assets do not overlap)
- Enforces a minimum size for the phantom window

BUG=335443
TEST=Manual, see bug

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248581

[pkotwicz, 2014-01-24 20:56:43]

Stefan, can you please take a look?

I do not use the minimum size when using the current window control style
because we animate the phantom window to size 0x0 when showing a preview for the
minimize animation when the shelf is auto hidden.

[pkotwicz, 2014-01-28 16:05:52]

Ping?

[Mr4D (OOO till 08-26), 2014-01-28 17:45:25]

Only one question.

https://codereview.chromium.org/147103003/diff/280001/ash/wm/workspace/phanto...
File ash/wm/workspace/phantom_window_controller.cc (right):

https://codereview.chromium.org/147103003/diff/280001/ash/wm/workspace/phanto...
ash/wm/workspace/phantom_window_controller.cc:152: void
PhantomWindowController::Show(const gfx::Rect& bounds_in_screen) {
Couldn't you get the GetAdjustedBounds only once here?

Or even better - GetAdjustedBounds only changes things when 
UseAlternateFrameCaptionButtonStyle is set. You do the same check in line 157
and you could return in line 174. Wouldn't it be much clearer to call from Show
into either ShowAlternate and / or ShowLegacy? That would also make this long
function better readable and avoids calling that function in the legacy case
altogether.

[pkotwicz, 2014-01-28 22:01:04]

Done! Stefan, can you please take another look?

[Mr4D (OOO till 08-26), 2014-01-28 22:06:30]

lgtm. Thanks for changing that!

[pkotwicz, 2014-01-28 22:20:55]

jamescook@ for OWNERS

[James Cook, 2014-01-28 22:51:37]

lgtm

[pkotwicz, 2014-02-03 19:32:09]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-02-03 19:33:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/147103003/470001

[commit-bot: I haz the power, 2014-02-03 21:53:09]

Change committed as 248581

[commit-bot: I haz the power, 2014-02-03 21:53:13]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 21:53:17]

CQ bit was unchecked on CL. Ignoring.