Linker: Do not require JNI_OnLoad in ModernLinker loads.

Linker: Do not require JNI_OnLoad in ModernLinker loads.

LegacyLinker uses the android_crazy_linker to load libraries.
The crazy linker calls JNI_OnLoad if present, but does not
fail the load if it is not present.

Current ModernLinker will fail if the loaded library does not
contain JNI_OnLoad. Change ModernLinker to match the crazy
linker behaviour here.

Ref:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp&l=444

Additionally, fix nearby comment cut-and-paste error.

Committed: https://crrev.com/ae60ba7f8a0e7d2cc3dd208219f8b9fa4f66ef1c
Cr-Commit-Position: refs/heads/master@{#361633}

[simonb (inactive), 2015-11-23 18:11:29]

Description was changed from

==========
Linker: Do not require JNI_OnLoad in ModernLinker loads.

LegacyLinker uses the android_crazy_linker to load libraries.
The crazy linker calls JNI_OnLoad if present, but does not
fail the load if it is not present.

Current ModernLinker will fail if the loaded library does not
contain JNI_OnLoad. Change ModernLinker to match the crazy
linker behaviour here.

Ref:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/androi...
==========

to

==========
Linker: Do not require JNI_OnLoad in ModernLinker loads.

LegacyLinker uses the android_crazy_linker to load libraries.
The crazy linker calls JNI_OnLoad if present, but does not
fail the load if it is not present.

Current ModernLinker will fail if the loaded library does not
contain JNI_OnLoad. Change ModernLinker to match the crazy
linker behaviour here.

Ref:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/androi...

Additionally, fix nearby comment cut-and-paste error.
==========

[simonb (inactive), 2015-11-23 18:53:01]

simonb@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[simonb (inactive), 2015-11-25 11:27:07]

simonb@chromium.org changed reviewers:
+ torne@chromium.org
- rmcilroy@chromium.org

[simonb (inactive), 2015-11-25 11:28:03]

Torne, would you mind doing the honours here? Small and non-controversial
change, would be good to get it off my plate before vacation. Thx.

[Torne, 2015-11-25 11:30:31]

lgtm

[simonb (inactive), 2015-11-25 11:54:02]

The CQ bit was checked by simonb@chromium.org

[commit-bot: I haz the power, 2015-11-25 11:54:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471023002/1

[commit-bot: I haz the power, 2015-11-25 12:37:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-25 12:38:59]

Patchset 1 (id:??) landed as
https://crrev.com/ae60ba7f8a0e7d2cc3dd208219f8b9fa4f66ef1c
Cr-Commit-Position: refs/heads/master@{#361633}