Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1471003005: Show tooltips for nested folders in the bookmark bar. (Closed)

Created:
5 years ago by Elly Fong-Jones
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show tooltips for nested folders in the bookmark bar. Without these tooltips, there's no way to read long folder names. BUG=551259 Committed: https://crrev.com/32c6bec9ae1363880fa48478a216f22e1f88737f Cr-Commit-Position: refs/heads/master@{#361388}

Patch Set 1 #

Patch Set 2 : Remove obsolete unit test fragment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 1 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Elly Fong-Jones
mark: ptal?
5 years ago (2015-11-24 15:01:22 UTC) #4
Mark Mentovai
LGTM
5 years ago (2015-11-24 15:08:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471003005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471003005/1
5 years ago (2015-11-24 15:29:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145320)
5 years ago (2015-11-24 16:42:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471003005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471003005/20001
5 years ago (2015-11-24 17:50:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 18:23:44 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-24 18:24:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32c6bec9ae1363880fa48478a216f22e1f88737f
Cr-Commit-Position: refs/heads/master@{#361388}

Powered by Google App Engine
This is Rietveld 408576698