Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 14710015: Prevent flushing of code that was set with %SetCode. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger
Modified:
7 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Prevent flushing of code that was set with %SetCode. This makes sure that shared function infos that break the one-to-one mapping to code are marked as un-flushable. Otherwise enqueuing through the GC meta-data field in the code object doesn't work. R=rossberg@chromium.org TEST=cctest/test-api/Threading4 Committed: http://code.google.com/p/v8/source/detail?r=14635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M src/bootstrapper.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-visiting-inl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/runtime.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 7 months ago (2013-05-13 10:30:56 UTC) #1
rossberg
lgtm
7 years, 7 months ago (2013-05-13 10:40:11 UTC) #2
Michael Starzinger
7 years, 7 months ago (2013-05-13 10:59:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14635 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698