Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1470963002: Decouple iOS port from ChromeMetricsServiceClient (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
blundell, chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Decouple iOS port from ChromeMetricsServiceClient This CL changes the iOS port to use IOSChromeMetricsServiceClient rather than its forked version of ChromeMetricsServiceClient. There is one intended functional change in that ChromeMetricsServiceClient::RecordCommandLineMetrics() was not ported to IOSChromeMetricsServiceClient; see crbug.com/375794 for details. Other than that, there should be no functional changes. BUG=512421, 375794 Committed: https://crrev.com/ffd40bdeab1188a8a173cb709da44d0559bda650 Cr-Commit-Position: refs/heads/master@{#361103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/prefs/browser_prefs.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look. blundell: FYI
5 years, 1 month ago (2015-11-23 15:10:44 UTC) #2
droger
lgtm
5 years, 1 month ago (2015-11-23 15:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470963002/1
5 years, 1 month ago (2015-11-23 15:20:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 15:28:35 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:30:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffd40bdeab1188a8a173cb709da44d0559bda650
Cr-Commit-Position: refs/heads/master@{#361103}

Powered by Google App Engine
This is Rietveld 408576698