Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1470913004: Remove staging for SkImageDecoder::Peeker (Closed)

Created:
5 years, 1 month ago by scroggo
Modified:
5 years ago
Reviewers:
msarett, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove staging for SkImageDecoder::Peeker Will no longer be needed once ag/817367 lands - Android will be inheriting directly from SkPngChunkReader, so no need for the intermediate. BUG=skia:4574 Committed: https://skia.googlesource.com/skia/+/f01610effccd3fba2be5cec5dc10fbf9af5744a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageDecoder.h View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
scroggo
5 years ago (2015-12-03 17:27:55 UTC) #2
msarett
lgtm
5 years ago (2015-12-03 18:16:32 UTC) #3
reed1
api lgtm
5 years ago (2015-12-03 19:40:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470913004/1
5 years ago (2015-12-08 22:03:24 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 02:48:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f01610effccd3fba2be5cec5dc10fbf9af5744a0

Powered by Google App Engine
This is Rietveld 408576698