third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp - Issue 1470893002: [Fetch] Always use utf-8 for decoding in text()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

Issue 1470893002: [Fetch] Always use utf-8 for decoding in text() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add fixes. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp b/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

index 107453c0547a8cdb3a5c3e064d01070208c5b9ee..4bff1ac95c353a654248256f7c3c12b6441073a5 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp

@@ -218,7 +218,7 @@ protected:

ASSERT(!m_decoder);

ASSERT(!m_reader);

m_client = client;

- m_decoder = TextResourceDecoder::create("text/plain", UTF8Encoding());

+ m_decoder = TextResourceDecoder::create("text/plain", UTF8Encoding(), false, TextResourceDecoder::CheckForOnlyUTF8BOM);

m_reader = handle->obtainReader(this);

}