Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1470873002: Enable webaudio unit tests iff ENABLE(WEB_AUDIO). (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years ago
Reviewers:
tkent, Raymond Toy
CC:
blink-reviews, chromium-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable webaudio unit tests iff ENABLE(WEB_AUDIO). R=tkent BUG= Committed: https://crrev.com/73a81be779f1eac6278ffc20b8ed3ef98474b2b5 Cr-Commit-Position: refs/heads/master@{#361171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ConvolverNodeTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/ScriptProcessorNodeTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/StereoPannerNodeTest.cpp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-23 10:54:33 UTC) #2
tkent
lgtm
5 years ago (2015-11-23 14:45:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470873002/1
5 years ago (2015-11-23 19:56:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-23 20:21:23 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-23 20:22:52 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73a81be779f1eac6278ffc20b8ed3ef98474b2b5
Cr-Commit-Position: refs/heads/master@{#361171}

Powered by Google App Engine
This is Rietveld 408576698