Aura on Android: Common GN build overrides.

Aura on Android: Common GN build overrides.

Creates a common config file which Aura on Android developers can import at "gn args".

BUG=507792
Committed: https://crrev.com/ad26484e8d5ad64a170ca97ea2330044e4168ef8
Cr-Commit-Position: refs/heads/master@{#361663}

[Hadi, 2015-11-23 21:16:18]

moshayedi@chromium.org changed reviewers:
+ brettw@chromium.org, mfomitchev@chromium.org, sievers@chromium.org

[Hadi, 2015-11-23 21:16:19]

Please take a look.

Based on internal discussion, we're creating a common config file that we can
import at gn args.

[Hadi, 2015-11-23 21:17:46]

Description was changed from

==========
Aura on Android: Common GN build overrides.

BUG=507792
==========

to

==========
Aura on Android: Common GN build overrides.

Creates a common config file which Aura on Android developers can import at "gn
args".

BUG=507792
==========

[mfomitchev, 2015-11-24 02:53:21]

https://codereview.chromium.org/1470863005/diff/1/build/config/android/aura_c...
File build/config/android/aura_config.gni (right):

https://codereview.chromium.org/1470863005/diff/1/build/config/android/aura_c...
build/config/android/aura_config.gni:11: is_component_build = true
I don't think this should be here. Whether to make a component or non-component
build is orthogonal to the whole Aura thing. (E.g. component builds are faster
to do, but the resulting APK takes up more space).

[Hadi, 2015-11-24 15:28:47]

https://codereview.chromium.org/1470863005/diff/1/build/config/android/aura_c...
File build/config/android/aura_config.gni (right):

https://codereview.chromium.org/1470863005/diff/1/build/config/android/aura_c...
build/config/android/aura_config.gni:11: is_component_build = true
On 2015/11/24 02:53:21, mfomitchev wrote:
> I don't think this should be here. Whether to make a component or
non-component
> build is orthogonal to the whole Aura thing. (E.g. component builds are faster
> to do, but the resulting APK takes up more space).

Makes sense. Done.

[mfomitchev, 2015-11-24 16:07:21]

LGTM

[brettw, 2015-11-24 18:33:46]

I think we need a new location for this type of file. Putting it into
build/config seems potentially confusing since people will look there for .gni
files to import into BUILD files, and importing this one will do very strange
things!

What do you guys think about
  build/args/*
or
  build/overrides/*

[Hadi, 2015-11-24 18:42:10]

On 2015/11/24 18:33:46, brettw wrote:
> I think we need a new location for this type of file. Putting it into
> build/config seems potentially confusing since people will look there for .gni
> files to import into BUILD files, and importing this one will do very strange
> things!
> 
> What do you guys think about
>   build/args/*
> or
>   build/overrides/*

Do you mean creating a new directory like build/args/ or build/overrides/ and
moving this file to there? Sounds good to me.

Initially I was considering putting this file in src/build_overrides, but after
reading the README there it seemed that it's not intended for uses like this.
So, since having both build/overrides/ and build_overrides/ might be confusing,
I'd suggest to go with build/args.

If we go with build/args, does moving the file as build/args/aura_android.gni
sound good?

[Hadi, 2015-11-24 22:08:48]

On 2015/11/24 18:33:46, brettw wrote:
> I think we need a new location for this type of file. Putting it into
> build/config seems potentially confusing since people will look there for .gni
> files to import into BUILD files, and importing this one will do very strange
> things!
> 
> What do you guys think about
>   build/args/*
> or
>   build/overrides/*

Just submitted a new patch set which puts the config file at
build/args/aura_android.gni. Does this look good?

Thanks.

[brettw, 2015-11-24 22:26:04]

lgtm

[no sievers, 2015-11-24 22:45:29]

lgtm

https://codereview.chromium.org/1470863005/diff/40001/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1470863005/diff/40001/build/config/features.g...
build/config/features.gni:166: 
I was also just wondering why not everything is inside declare_args().
(I came across other stuff we might want to turn off in the interim, which has
dependencies on java.)

[Hadi, 2015-11-25 15:05:37]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2015-11-25 15:05:37]

The CQ bit was unchecked by moshayedi@chromium.org

[Hadi, 2015-11-25 15:05:37]

The CQ bit was checked by moshayedi@chromium.org

[Hadi, 2015-11-25 15:05:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mfomitchev@chromium.org
Link to the patchset: https://codereview.chromium.org/1470863005/#ps40001
(title: "Move the config file to build/args.")

[Hadi, 2015-11-25 15:05:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mfomitchev@chromium.org
Link to the patchset: https://codereview.chromium.org/1470863005/#ps40001
(title: "Move the config file to build/args.")

[commit-bot: I haz the power, 2015-11-25 15:06:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470863005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470863005/40001

[commit-bot: I haz the power, 2015-11-25 15:36:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-25 15:37:40]

Patchset 3 (id:??) landed as
https://crrev.com/ad26484e8d5ad64a170ca97ea2330044e4168ef8
Cr-Commit-Position: refs/heads/master@{#361663}