Add avatar syncing for supervised users.

Add avatar syncing for supervised users.

When the supervised user changes his avatar, the change is
synced to his other devices, as well as to the settings of
the custodian who sees the updated avatar when opening the
supervised user import overlay.

BUG=339060
TEST=unit_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251044

[Adrian Kuegel, 2014-02-06 16:57:02]

Bernhard, can you please review this CL?

Denis, as promised, I put you on cc. This is just the Chrome part for avatar
syncing, but it would already set a ChromeOS avatar as shared managed user
setting.

[Bernhard Bauer, 2014-02-07 09:54:23]

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_user_registration_utility.h (right):

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_user_registration_utility.h:23: class
ManagedUserSharedSettingsService;
Nit: Keep sorted please.

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
File chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc
(right):

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc:16: const
int kNoAvatar = -1;
Nit: const variables automatically get internal linkage, so the anonymous
namespace isn't really necessary.

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc:67: if
(mu_id != managed_user_id_ || key != managed_users::kChromeAvatarIndex)
Can you DCHECK that we are being called with our own mu_id?

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
File
chrome/browser/managed_mode/supervised_user_pref_mapping_service_unittest.cc
(right):

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/supervised_user_pref_mapping_service_unittest.cc:19:
const std::string kFakeManagedUserId = "fakeID";
const char[], otherwise you'll get a static initializer. Also, same note here
about const automatically getting internal linkage.

[Adrian Kuegel, 2014-02-07 10:24:47]

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
File chrome/browser/managed_mode/managed_user_registration_utility.h (right):

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/managed_user_registration_utility.h:23: class
ManagedUserSharedSettingsService;
On 2014/02/07 09:54:24, Bernhard Bauer wrote:
> Nit: Keep sorted please.

Right. Somehow it seems I thought S is before R in alphabet ;-) Done.

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
File chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc
(right):

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc:16: const
int kNoAvatar = -1;
On 2014/02/07 09:54:24, Bernhard Bauer wrote:
> Nit: const variables automatically get internal linkage, so the anonymous
> namespace isn't really necessary.

Done.

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc:67: if
(mu_id != managed_user_id_ || key != managed_users::kChromeAvatarIndex)
On 2014/02/07 09:54:24, Bernhard Bauer wrote:
> Can you DCHECK that we are being called with our own mu_id? 

A, right, since the SupervisedUserPrefMappingService always is attached to a
supervised user profile, we can be sure of that. Done.

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
File
chrome/browser/managed_mode/supervised_user_pref_mapping_service_unittest.cc
(right):

https://codereview.chromium.org/147083016/diff/50001/chrome/browser/managed_m...
chrome/browser/managed_mode/supervised_user_pref_mapping_service_unittest.cc:19:
const std::string kFakeManagedUserId = "fakeID";
On 2014/02/07 09:54:24, Bernhard Bauer wrote:
> const char[], otherwise you'll get a static initializer. Also, same note here
> about const automatically getting internal linkage.

Done.

[Bernhard Bauer, 2014-02-07 11:10:24]

LGTM with a nit:

https://codereview.chromium.org/147083016/diff/140003/chrome/browser/managed_...
File chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc
(right):

https://codereview.chromium.org/147083016/diff/140003/chrome/browser/managed_...
chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc:63:
DCHECK(mu_id == managed_user_id_);
Nit: DCHECK_EQ will give a nicer error message when the check fails.

[Adrian Kuegel, 2014-02-07 11:49:45]

https://codereview.chromium.org/147083016/diff/140003/chrome/browser/managed_...
File chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc
(right):

https://codereview.chromium.org/147083016/diff/140003/chrome/browser/managed_...
chrome/browser/managed_mode/supervised_user_pref_mapping_service.cc:63:
DCHECK(mu_id == managed_user_id_);
On 2014/02/07 11:10:24, Bernhard Bauer wrote:
> Nit: DCHECK_EQ will give a nicer error message when the check fails.

Done.

[Adrian Kuegel, 2014-02-07 11:51:47]

Just FYI: I will not commit this CL yet, because there is still the issue that
you get an email if a setting change was acknowledged. My CL to fix this has not
been pushed to the Chrome Sync Server yet.

[Adrian Kuegel, 2014-02-13 09:22:13]

The CQ bit was checked by akuegel@chromium.org

[commit-bot: I haz the power, 2014-02-13 09:22:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/akuegel@chromium.org/147083016/400002

[commit-bot: I haz the power, 2014-02-13 16:08:53]

Change committed as 251044