Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147083011: common.gypi: When clang=1 on Windows, set CC to clang-cl (Closed)

Created:
6 years, 10 months ago by hans
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

common.gypi: When clang=1 on Windows, set CC to clang-cl (See https://code.google.com/p/gyp/source/detail?r=1846 for how GYP deals with this.) BUG=82385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247586

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't set CC.host #

Patch Set 3 : Actually don't set CXX either since it's not used #

Patch Set 4 : rietveld sad #

Total comments: 1

Patch Set 5 : Optional tweak #

Patch Set 6 : Optional tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/common.gypi View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hans
Please take a look.
6 years, 10 months ago (2014-01-28 23:48:37 UTC) #1
Nico
https://codereview.chromium.org/147083011/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/147083011/diff/1/build/common.gypi#newcode4786 build/common.gypi:4786: ['CXX.host', '$(CXX)'], Don't set CC.host, it's ignored.
6 years, 10 months ago (2014-01-28 23:50:31 UTC) #2
hans
https://codereview.chromium.org/147083011/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/147083011/diff/1/build/common.gypi#newcode4786 build/common.gypi:4786: ['CXX.host', '$(CXX)'], On 2014/01/28 23:50:32, Nico wrote: > Don't ...
6 years, 10 months ago (2014-01-28 23:55:48 UTC) #3
hans
Now with less CXX.
6 years, 10 months ago (2014-01-29 00:00:53 UTC) #4
Nico
lgtm with optional tweak https://codereview.chromium.org/147083011/diff/60001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/147083011/diff/60001/build/common.gypi#newcode4782 build/common.gypi:4782: 'make_global_settings': [ Maybe say `# ...
6 years, 10 months ago (2014-01-29 00:01:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/147083011/60002
6 years, 10 months ago (2014-01-29 00:03:55 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 01:59:23 UTC) #7
Message was sent while issue was closed. 
Change committed as 247586

Powered by Google App Engine
This is Rietveld 408576698