Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147083008: Add a test case for navigator.isProtocolHandlerRegistered (Closed)

Created:
6 years, 10 months ago by gyuyoung-inactive
Modified:
6 years, 10 months ago
CC:
blink-reviews, gyuyoung.kim_webkit.org, haraken
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add a test case for navigator.isProtocolHandlerRegistered Add a test case for navigator.isProtocolHandlerRegistered "navigator.isProtocolHandlerRegistered" throws the proper exceptions and returns the default state of handler. TEST=fast/dom/navigatorcontentutils/is-protocol-handler-registered.html BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165944

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
A LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered-expected.txt View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gyuyoung-inactive
Add abarth and jochen.
6 years, 10 months ago (2014-01-28 05:01:15 UTC) #1
gyuyoung-inactive
6 years, 10 months ago (2014-01-28 05:02:13 UTC) #2
jochen (gone - plz use gerrit)
lgtm you could consider using js-test.js instead of your own debug() methods https://chromiumcodereview.appspot.com/147083008/diff/10001/LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html File LayoutTests/fast/dom/navigatorcontentutils/is-protocol-handler-registered.html ...
6 years, 10 months ago (2014-01-28 13:13:23 UTC) #3
gyuyoung-inactive
On 2014/01/28 13:13:23, jochen wrote: > lgtm > > you could consider using js-test.js instead ...
6 years, 10 months ago (2014-01-28 13:18:01 UTC) #4
gyuyoung-inactive
On 2014/01/28 13:18:01, gyuyoung wrote: > On 2014/01/28 13:13:23, jochen wrote: > > lgtm > ...
6 years, 10 months ago (2014-01-28 14:27:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/147083008/20001
6 years, 10 months ago (2014-01-28 14:28:54 UTC) #6
gyuyoung-inactive
On 2014/01/28 14:28:54, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 10 months ago (2014-01-28 14:41:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/147083008/40001
6 years, 10 months ago (2014-01-28 14:41:49 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-28 15:46:19 UTC) #9
Message was sent while issue was closed. 
Change committed as 165944

Powered by Google App Engine
This is Rietveld 408576698