content/browser/security_exploit_browsertest.cc - Issue 1470823002: Enable builtin Mojo JS modules in layout tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 1470823002: Enable builtin Mojo JS modules in layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@usb-testing

Patch Set: self review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/public/browser/content_browser_client.h » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/security_exploit_browsertest.cc

diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc

index dcf51ef65a4fcd10cff2329c3bd604c9e6ae07da..93970344ff4fe32a698d7712f3b4f7f86ce46a78 100644

--- a/content/browser/security_exploit_browsertest.cc

+++ b/content/browser/security_exploit_browsertest.cc

@@ -21,6 +21,7 @@

#include "content/public/browser/interstitial_page_delegate.h"

#include "content/public/browser/storage_partition.h"

#include "content/public/common/appcache_info.h"

+#include "content/public/common/bindings_policy.h"

#include "content/public/common/content_switches.h"

#include "content/public/common/file_chooser_params.h"

#include "content/public/test/browser_test_utils.h"

@@ -178,8 +179,9 @@ IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest, SetWebUIProperty) {

NavigateToURL(shell(), foo);

EXPECT_EQ(base::ASCIIToUTF16("OK"), shell()->web_contents()->GetTitle());

- EXPECT_EQ(0,

- shell()->web_contents()->GetRenderViewHost()->GetEnabledBindings());

+ EXPECT_FALSE(

+ shell()->web_contents()->GetRenderViewHost()->GetEnabledBindings() &

+ BINDINGS_POLICY_WEB_UI);

RenderProcessHostWatcher terminated(

shell()->web_contents(),