Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1470823002: Enable builtin Mojo JS modules in layout tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@usb-testing
Patch Set: add 'define' to global interface expectations for AMD in layout tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 84e6d1af9bb17da005014f5b438e4377adf6c9d2..6d1ad358a42b21c34c9d25e0823ff9b543d056f0 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2359,8 +2359,14 @@ void RenderViewImpl::OnAllowBindings(int enabled_bindings_flags) {
!(enabled_bindings_ & BINDINGS_POLICY_WEB_UI)) {
// WebUIExtensionData deletes itself when we're destroyed.
new WebUIExtensionData(this);
+ }
- if (main_render_frame_)
+ if (main_render_frame_ &&
+ !(enabled_bindings_ & (BINDINGS_POLICY_WEB_UI | BINDINGS_POLICY_MOJO)) &&
+ (enabled_bindings_flags &
+ (BINDINGS_POLICY_WEB_UI | BINDINGS_POLICY_MOJO))) {
Charlie Reis 2016/01/26 01:01:02 Looks right, but would one of your tests catch it
Ken Rockot(use gerrit already) 2016/01/26 01:32:55 Yeah - the layout tests cover the affirmative case
+ // Enable Mojo bindings iff either WebUI or Mojo bindings are being added
+ // to the policy and neither was present before.
main_render_frame_->EnableMojoBindings();
}

Powered by Google App Engine
This is Rietveld 408576698