Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2915)

Unified Diff: chrome/browser/ssl/security_state_model_unittest.cc

Issue 1470813002: Add SecurityStateModelClient interface and implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: blundell comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/security_state_model_unittest.cc
diff --git a/chrome/browser/ssl/security_state_model_unittest.cc b/chrome/browser/ssl/security_state_model_unittest.cc
index b8f15f8aab3b362975aaff8ac7e9c7923601cf81..762534d2a8296d98fa1bc9587ee556c88d560e9f 100644
--- a/chrome/browser/ssl/security_state_model_unittest.cc
+++ b/chrome/browser/ssl/security_state_model_unittest.cc
@@ -44,7 +44,7 @@ TEST_F(SecurityStateModelTest, SHA1Warning) {
content::SSLStatus ssl_status;
ASSERT_NO_FATAL_FAILURE(GetTestSSLStatus(process()->GetID(), &ssl_status));
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_EQ(SecurityStateModel::DEPRECATED_SHA1_MINOR,
security_info.sha1_deprecation_status);
EXPECT_EQ(SecurityStateModel::NONE, security_info.security_level);
@@ -60,7 +60,7 @@ TEST_F(SecurityStateModelTest, SHA1WarningMixedContent) {
ASSERT_NO_FATAL_FAILURE(GetTestSSLStatus(process()->GetID(), &ssl_status));
ssl_status.content_status = content::SSLStatus::DISPLAYED_INSECURE_CONTENT;
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_EQ(SecurityStateModel::DEPRECATED_SHA1_MINOR,
security_info.sha1_deprecation_status);
EXPECT_EQ(SecurityStateModel::DISPLAYED_MIXED_CONTENT,
@@ -70,7 +70,7 @@ TEST_F(SecurityStateModelTest, SHA1WarningMixedContent) {
ssl_status.security_style = content::SECURITY_STYLE_AUTHENTICATION_BROKEN;
ssl_status.content_status = content::SSLStatus::RAN_INSECURE_CONTENT;
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_EQ(SecurityStateModel::DEPRECATED_SHA1_MINOR,
security_info.sha1_deprecation_status);
EXPECT_EQ(SecurityStateModel::RAN_MIXED_CONTENT,
@@ -89,7 +89,7 @@ TEST_F(SecurityStateModelTest, SHA1WarningBrokenHTTPS) {
ssl_status.security_style = content::SECURITY_STYLE_AUTHENTICATION_BROKEN;
ssl_status.cert_status |= net::CERT_STATUS_DATE_INVALID;
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_EQ(SecurityStateModel::DEPRECATED_SHA1_MINOR,
security_info.sha1_deprecation_status);
EXPECT_EQ(SecurityStateModel::SECURITY_ERROR, security_info.security_level);
@@ -111,7 +111,7 @@ TEST_F(SecurityStateModelTest, SecureProtocolAndCiphersuite) {
net::SSLConnectionStatusSetCipherSuite(ciphersuite,
&ssl_status.connection_status);
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_TRUE(security_info.is_secure_protocol_and_ciphersuite);
}
@@ -129,7 +129,7 @@ TEST_F(SecurityStateModelTest, NonsecureProtocol) {
net::SSLConnectionStatusSetCipherSuite(ciphersuite,
&ssl_status.connection_status);
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_FALSE(security_info.is_secure_protocol_and_ciphersuite);
}
@@ -147,7 +147,7 @@ TEST_F(SecurityStateModelTest, NonsecureCiphersuite) {
net::SSLConnectionStatusSetCipherSuite(ciphersuite,
&ssl_status.connection_status);
SecurityStateModel::SecurityInfoForRequest(url, ssl_status, test_profile,
- &security_info);
+ false, &security_info);
EXPECT_FALSE(security_info.is_secure_protocol_and_ciphersuite);
}

Powered by Google App Engine
This is Rietveld 408576698