Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1470803002: [stubs] Change CallICStub to utilize the ConvertReceiverMode. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Change CallICStub to utilize the ConvertReceiverMode. The CallICStub has call-site specific knowledge about the receiver, which we did not utilize; plus the CallICStub does in some case know whether it is about to [[Call]] a function or potentially some other callable. In the common case we actually know that the target is a function and so we can use the CallFunction builtin directly instead of redispatching in the Call builtin. BUG=chromium:555127, v8:4413 LOG=n Committed: https://crrev.com/d80fd48e5d3d401c10ce95cf8430e5caa9984e32 Cr-Commit-Position: refs/heads/master@{#32163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -34 lines) Patch
M src/arm/code-stubs-arm.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Yang, Some trivial performance improvements. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-23 05:50:36 UTC) #2
Yang
On 2015/11/23 05:50:36, Benedikt Meurer wrote: > Hey Yang, > > Some trivial performance improvements. ...
5 years, 1 month ago (2015-11-23 06:40:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470803002/1
5 years, 1 month ago (2015-11-23 06:40:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 06:42:05 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 06:42:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d80fd48e5d3d401c10ce95cf8430e5caa9984e32
Cr-Commit-Position: refs/heads/master@{#32163}

Powered by Google App Engine
This is Rietveld 408576698