Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 14708005: Add build/linux/unbundle files for projects in separate repos. (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Add build/linux/unbundle files for projects in separate repos. The removal of use_system_foo logic from the original gyp files will follow. BUG=226860 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -31 lines) Patch
A + build/linux/unbundle/flac.gyp View 2 chunks +13 lines, -14 lines 0 comments Download
A build/linux/unbundle/icu.gyp View 1 chunk +216 lines, -0 lines 0 comments Download
A + build/linux/unbundle/libvpx.gyp View 1 chunk +21 lines, -17 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 chunk +5 lines, -0 lines 0 comments Download
A build/linux/unbundle/speex.gyp View 1 chunk +45 lines, -0 lines 0 comments Download
A build/linux/unbundle/v8.gyp View 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-02 00:21:08 UTC) #1
Ryan Sleevi
rubberstamp LGTM, nothing looks ornery here.
7 years, 7 months ago (2013-05-02 00:28:47 UTC) #2
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-02 16:30:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r197927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698