Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1470793004: X87: Adopt the fix of the sqrt precision issue from TurboFan to CrankShaft. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Adopt the fix of the sqrt precision issue from TurboFan to CrankShaft. port 4e0045647192f300e02e98927180b799f644a3ed (r31625) original commit message: X87: Fix the sqrt precision issue. In order to resolve the sqrt precision issue described in https://codereview.chromium.org/1425763002/. we change the implementation of CreateSqrtFunction() implementation of X87 so that the optimize compiler and full-compiler implementation are unified. BUG= Committed: https://crrev.com/fb633b0cc4f829438ed732536c90fc32765401a1 Cr-Commit-Position: refs/heads/master@{#32166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -59 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +5 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-23 07:57:36 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-23 08:32:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470793004/1
5 years, 1 month ago (2015-11-23 08:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 08:50:38 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 08:51:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb633b0cc4f829438ed732536c90fc32765401a1
Cr-Commit-Position: refs/heads/master@{#32166}

Powered by Google App Engine
This is Rietveld 408576698