Issue 1470793002: Don't run 'pub list-package-dirs' if there is no pubpsec.lock file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1470793002: Don't run 'pub list-package-dirs' if there is no pubpsec.lock file. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't run 'pub list-package-dirs' if there is no pubpsec.lock file. This should help on DAS startup - if we don't have to run Pub, this saves as much as 400ms for each pubspec.yaml file. Without pubspec.yaml we won't get any results anyway. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ac24bd115c39b6733a2ffb36df219106df9043c8

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -103 lines)			Patch
M	pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/source/pub_package_map_provider.dart	View	2 chunks	+15 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/source/package_map_provider_test.dart	View	1 chunk	+112 lines, -99 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 1 month ago (2015-11-23 17:19:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ac24bd115c39b6733a2ffb36df219106df9043c8 (presubmit successful).