Timeline: do not show percent columns in Events tree view

third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.VBox}
  * @param {!WebInspector.TimelineModel} model
  */
 WebInspector.TimelineTreeView = function(model)
@@ skipping 47 matching lines @@
      * @param {number} endTime
      */
     setRange: function(startTime, endTime)
     {
         this._startTime = startTime;
         this._endTime = endTime;
         this._refreshTree();
     },
 
     /**
+     * @return {boolean}
+     */
+    _exposePercentages: function()
+    {
+        return false;
+    },
+
+    /**
      * @param {!Element} parent
      */
     _populateToolbar: function(parent) { },
 
     /**
      * @param {!ConsoleAgent.CallFrame} frame
      * @return {!Element}
      */
     linkifyLocation: function(frame)
     {
@@ skipping 248 matching lines @@
     },
 
     /**
      * @param {string} columnIdentifier
      * @return {?Element}
      */
     _createValueCell: function(columnIdentifier)
     {
         if (columnIdentifier !== "self" && columnIdentifier !== "total" && columnIdentifier !== "startTime")
             return null;
-        /**
-         * @param {number} time
-         * @return {string}
-         */
-        function formatMilliseconds(time)
-        {
-            return WebInspector.UIString("%.1f\u2009ms", time);
-        }
-        /**
-         * @param {number} value
-         * @return {string}
-         */
-        function formatPercent(value)
-        {
-            return WebInspector.UIString("%.1f\u2009%%", value);
-        }
 
+        var showPercents = false;
         var value;
-        var percentText;
         var maxTime;
         switch (columnIdentifier) {
         case "startTime":
             value = this._profileNode.event.startTime - this._treeView._model.minimumRecordTime();
             break;
         case "self":
             value = this._profileNode.selfTime;
-            percentText = formatPercent(this._profileNode.selfTime / this._grandTotalTime * 100);
             maxTime = this._maxSelfTime;
+            showPercents = true;
             break;
         case "total":
             value = this._profileNode.totalTime;
-            percentText = formatPercent(this._profileNode.totalTime / this._grandTotalTime * 100);
             maxTime = this._maxTotalTime;
+            showPercents = true;
             break;
         default:
             return null;
         }
         var cell = this.createTD(columnIdentifier);
         cell.className = "numeric-column";
         var textDiv = cell.createChild("div");
-        textDiv.createChild("span").textContent = formatMilliseconds(value);
-        if (percentText) {
-            textDiv.createChild("span", "percent-column").textContent = percentText;
-            textDiv.classList.add("profile-multiple-values");
+        textDiv.createChild("span").textContent = WebInspector.UIString("%.1f\u2009ms", value);
+
+        if (showPercents && this._treeView._exposePercentages())
+            textDiv.createChild("span", "percent-column").textContent = WebInspector.UIString("%.1f\u2009%%", value / this._grandTotalTime * 100);
+        if (maxTime) {
+            textDiv.classList.add("background-percent-bar");
+            cell.createChild("div", "background-bar-container").createChild("div", "background-bar").style.width = (value * 100 / maxTime).toFixed(1) + "%";
         }
-        if (maxTime)
-            cell.createChild("div", "background-bar-container").createChild("div", "background-bar").style.width = (value * 100 / maxTime).toFixed(1) + "%";
         return cell;
     },
 
     /**
      * @override
      */
     populate: function()
     {
         if (this._populated)
             return;
@@ skipping 72 matching lines @@
                 this._groupByCombobox.select(option);
         }
         addGroupingOption.call(this, WebInspector.UIString("No Grouping"), WebInspector.AggregatedTimelineTreeView.GroupBy.None);
         addGroupingOption.call(this, WebInspector.UIString("Group by Category"), WebInspector.AggregatedTimelineTreeView.GroupBy.Category);
         addGroupingOption.call(this, WebInspector.UIString("Group by Domain"), WebInspector.AggregatedTimelineTreeView.GroupBy.Domain);
         addGroupingOption.call(this, WebInspector.UIString("Group by Subdomain"), WebInspector.AggregatedTimelineTreeView.GroupBy.Subdomain);
         addGroupingOption.call(this, WebInspector.UIString("Group by URL"), WebInspector.AggregatedTimelineTreeView.GroupBy.URL);
         panelToolbar.appendToolbarItem(this._groupByCombobox);
     },
 
+    /**
+     * @override
+     * @return {boolean}
+     */
+    _exposePercentages: function()
+    {
+        return true;
+    },
+
     _onGroupByChanged: function()
     {
         this._groupBySetting.set(this._groupByCombobox.selectedOption().value);
         this._refreshTree();
     },
 
     /**
      * @param {function(!WebInspector.TimelineModel.ProfileTreeNode):string} nodeToGroupId
      * @param {!WebInspector.TimelineModel.ProfileTreeNode} node
      * @return {!WebInspector.TimelineModel.ProfileTreeNode}
@@ skipping 309 matching lines @@
          * @this {WebInspector.EventsTimelineTreeView}
          */
         function showDetails(fragment)
         {
             this._detailsView.element.appendChild(fragment);
         }
     },
 
     __proto__: WebInspector.TimelineTreeView.prototype
 }