Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1470783002: Fix two issues with HoverHighlightView (Closed)

Created:
5 years, 1 month ago by fqj
Modified:
5 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul, cschuet (SLOW)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix two issues with HoverHighlightView 1) Set the enable status of icon and label before it's being added as a child of HoverHighlightView 2) Refuse SetHoverHightlight to true when disabled, and SetHoverHightlight to false when OnEnabledChanged triggered and enabled() changed to false. BUG=560013, 560027 Committed: https://crrev.com/b1d79c3bae7353740e891513770e8fccdb19b2f4 Cr-Commit-Position: refs/heads/master@{#361146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ash/system/tray/hover_highlight_view.cc View 7 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fqj
PTAL.
5 years, 1 month ago (2015-11-23 00:13:48 UTC) #2
stevenjb
lgtm
5 years, 1 month ago (2015-11-23 17:59:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470783002/1
5 years, 1 month ago (2015-11-23 18:09:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 18:22:16 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 18:23:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1d79c3bae7353740e891513770e8fccdb19b2f4
Cr-Commit-Position: refs/heads/master@{#361146}

Powered by Google App Engine
This is Rietveld 408576698