Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: pkg/analysis_server/test/services/correction/assist_test.dart

Issue 1470753002: Quick assist for converting block documentation comments into line ones. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/assist_internal.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/assist_test.dart
diff --git a/pkg/analysis_server/test/services/correction/assist_test.dart b/pkg/analysis_server/test/services/correction/assist_test.dart
index 61c164bf479d0d1b7a8a9cbe70f66be03b3b00c2..1d965e516a34c688c614649584d401f65f32caf4 100644
--- a/pkg/analysis_server/test/services/correction/assist_test.dart
+++ b/pkg/analysis_server/test/services/correction/assist_test.dart
@@ -845,7 +845,7 @@ void f() {}
await assertNoAssistAt('f();', DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE);
}
- test_convertIntoBlockDocumentationComment_BAD_alreadyBlock() async {
+ test_convertDocumentationIntoBlock_BAD_alreadyBlock() async {
resolveTestUnit('''
/**
* AAAAAAA
@@ -856,7 +856,7 @@ class A {}
'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK);
}
- test_convertIntoBlockDocumentationComment_BAD_notDocumentation() async {
+ test_convertDocumentationIntoBlock_BAD_notDocumentation() async {
resolveTestUnit('''
// AAAA
class A {}
@@ -865,7 +865,7 @@ class A {}
'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_BLOCK);
}
- test_convertIntoBlockDocumentationComment_OK_onReference() async {
+ test_convertDocumentationIntoBlock_OK_onReference() async {
resolveTestUnit('''
/// AAAAAAA [int] AAAAAAA
class A {}
@@ -881,7 +881,7 @@ class A {}
''');
}
- test_convertIntoBlockDocumentationComment_OK_onText() async {
+ test_convertDocumentationIntoBlock_OK_onText() async {
resolveTestUnit('''
class A {
/// AAAAAAA [int] AAAAAAA
@@ -905,6 +905,87 @@ class A {
''');
}
+ test_convertDocumentationIntoLine_BAD_alreadyLine() async {
+ resolveTestUnit('''
+/// AAAAAAA
+class A {}
+''');
+ await assertNoAssistAt(
+ 'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE);
+ }
+
+ test_convertDocumentationIntoLine_BAD_notDocumentation() async {
+ resolveTestUnit('''
+/* AAAA */
+class A {}
+''');
+ await assertNoAssistAt(
+ 'AAA', DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE);
+ }
+
+ test_convertDocumentationIntoLine_OK_onReference() async {
+ resolveTestUnit('''
+/**
+ * AAAAAAA [int] AAAAAAA
+ */
+class A {}
+''');
+ await assertHasAssistAt(
+ 'nt]',
+ DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE,
+ '''
+/// AAAAAAA [int] AAAAAAA
+class A {}
+''');
+ }
+
+ test_convertDocumentationIntoLine_OK_onText() async {
+ resolveTestUnit('''
+class A {
+ /**
+ * AAAAAAA [int] AAAAAAA
+ * BBBBBBBB BBBB BBBB
+ * CCC [A] CCCCCCCCCCC
+ */
+ mmm() {}
+}
+''');
+ await assertHasAssistAt(
+ 'AAA [',
+ DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE,
+ '''
+class A {
+ /// AAAAAAA [int] AAAAAAA
+ /// BBBBBBBB BBBB BBBB
+ /// CCC [A] CCCCCCCCCCC
+ mmm() {}
+}
+''');
+ }
+
+ test_convertDocumentationIntoLine_OK_onText_hasFirstLine() async {
+ resolveTestUnit('''
+class A {
+ /** AAAAAAA [int] AAAAAAA
+ * BBBBBBBB BBBB BBBB
+ * CCC [A] CCCCCCCCCCC
+ */
+ mmm() {}
+}
+''');
+ await assertHasAssistAt(
+ 'AAA [',
+ DartAssistKind.CONVERT_DOCUMENTATION_INTO_LINE,
+ '''
+class A {
+ /// AAAAAAA [int] AAAAAAA
+ /// BBBBBBBB BBBB BBBB
+ /// CCC [A] CCCCCCCCCCC
+ mmm() {}
+}
+''');
+ }
+
test_convertToBlockBody_OK_async() async {
resolveTestUnit('''
class A {
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/assist_internal.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698