Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1470753002: Quick assist for converting block documentation comments into line ones. (Closed)

Created:
5 years, 1 month ago by scheglov
Modified:
5 years, 1 month ago
Reviewers:
kevmoo, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Quick assist for converting block documentation comments into line ones. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/53e9cce24d6c3a9eccef94569f9d92f12f0ad09d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -6 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 3 chunks +51 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 5 chunks +85 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
scheglov
5 years, 1 month ago (2015-11-22 05:57:13 UTC) #1
pquitslund
\o/
5 years, 1 month ago (2015-11-22 17:48:00 UTC) #2
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-22 18:08:11 UTC) #3
kevmoo
FYI: our code style explicitly prefers /// style doc comments https://www.dartlang.org/effective-dart/documentation/#do-use--doc-comments-to-document-members-and-types
5 years, 1 month ago (2015-11-22 22:42:43 UTC) #5
Brian Wilkerson
Yes, that's one of the reasons we added this assist. (This assist converts from block ...
5 years, 1 month ago (2015-11-22 23:13:01 UTC) #6
kevmoo
On 2015/11/22 23:13:01, Brian Wilkerson wrote: > Yes, that's one of the reasons we added ...
5 years, 1 month ago (2015-11-22 23:17:36 UTC) #7
scheglov
5 years, 1 month ago (2015-11-23 03:57:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
53e9cce24d6c3a9eccef94569f9d92f12f0ad09d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698