SPDY - In CreateStream close the SpdySession if socket is not connected.

net/spdy/spdy_session.cc

Index: net/spdy/spdy_session.cc
===================================================================
--- net/spdy/spdy_session.cc	(revision 195932)
+++ net/spdy/spdy_session.cc	(working copy)
@@ -548,6 +548,18 @@
     return ERR_SPDY_PROTOCOL_ERROR;
   }
 
+  DCHECK(connection_->socket());
+  DCHECK(connection_->socket()->IsConnected());
+  if (connection_->socket() && !connection_->socket()->IsConnected()) {
+    UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",

[Ryan Hamilton, 2013/05/01 15:29:21]

I think I meant this:

if (connection_->socket()) {
  UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
      connection_->socket()->IsConnected());
  if (!connection_->socket()->IsConnected()) {
    CloseSessionOnError(...);
  }

In other words, each time we create a stream, we want to know if the socket is
connected or not and histogram that.

[ramant (doing other things), 2013/05/01 17:53:15]

Done.

+                          connection_->socket()->IsConnected());
+    CloseSessionOnError(
+        ERR_CONNECTION_CLOSED,
+        true,
+        "Tried to create SPDY stream for a closed socket connection.");
+    return ERR_CONNECTION_CLOSED;
+  }
+
   const std::string& path = request.url().PathForRequest();
   *stream = new SpdyStream(this, path, request.priority(),
                            stream_initial_send_window_size_,