SPDY - In CreateStream close the SpdySession if socket is not connected.

net/spdy/spdy_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 530 matching lines @@
     RecordProtocolErrorHistogram(
         PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION);
     CloseSessionOnError(
         static_cast<Error>(certificate_error_code_),
         true,
         "Tried to create SPDY stream for secure content over an "
         "unauthenticated session.");
     return ERR_SPDY_PROTOCOL_ERROR;
   }
 
+  DCHECK(connection_->socket());
+  DCHECK(connection_->socket()->IsConnected());
+  if (connection_->socket() && !connection_->socket()->IsConnected()) {
+    UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",

[Ryan Hamilton, 2013/05/01 15:29:21]

I think I meant this:

if (connection_->socket()) {
  UMA_HISTOGRAM_BOOLEAN("Net.SpdySession.CreateStreamWithSocketConnected",
      connection_->socket()->IsConnected());
  if (!connection_->socket()->IsConnected()) {
    CloseSessionOnError(...);
  }

In other words, each time we create a stream, we want to know if the socket is
connected or not and histogram that.

[ramant (doing other things), 2013/05/01 17:53:15]

Done.

+                          connection_->socket()->IsConnected());
+    CloseSessionOnError(
+        ERR_CONNECTION_CLOSED,
+        true,
+        "Tried to create SPDY stream for a closed socket connection.");
+    return ERR_CONNECTION_CLOSED;
+  }
+
   const std::string& path = request.url().PathForRequest();
   *stream = new SpdyStream(this, path, request.priority(),
                            stream_initial_send_window_size_,
                            stream_initial_recv_window_size_,
                            false, request.net_log());
   created_streams_.insert(*stream);
 
   UMA_HISTOGRAM_CUSTOM_COUNTS(
       "Net.SpdyPriorityCount",
       static_cast<int>(request.priority()), 0, 10, 11);
@@ skipping 1850 matching lines @@
     if (!queue->empty()) {
       SpdyStreamId stream_id = queue->front();
       queue->pop_front();
       return stream_id;
     }
   }
   return 0;
 }
 
 }  // namespace net