Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Issue 1470633002: ChromeOS: Fix removeUser button on signin screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@462823--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Fix-GetKnownUserAccountId
Patch Set: Rebased. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
index 0f5b3f02acae3b747be599a3ad1a0725d27dcc62..853fb5647ff13c7fb1d62cbbd6c1cbda7516cf26 100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
@@ -35,6 +35,7 @@
#include "ui/base/ime/chromeos/input_method_manager.h"
#include "ui/events/event_handler.h"
+class AccountId;
class EasyUnlockService;
namespace base {
@@ -77,7 +78,7 @@ class LoginDisplayWebUIHandler {
public:
virtual void ClearAndEnablePassword() = 0;
virtual void ClearUserPodPassword() = 0;
- virtual void OnUserRemoved(const std::string& username,
+ virtual void OnUserRemoved(const AccountId& account_id,
bool last_user_removed) = 0;
virtual void OnUserImageChanged(const user_manager::User& user) = 0;
virtual void OnPreferencesChanged() = 0;
@@ -166,7 +167,7 @@ class SigninScreenHandlerDelegate {
virtual void LoadSigninWallpaper() = 0;
// Attempts to remove given user.
- virtual void RemoveUser(const std::string& username) = 0;
+ virtual void RemoveUser(const AccountId& account_id) = 0;
// Let the delegate know about the handler it is supposed to be using.
virtual void SetWebUIHandler(LoginDisplayWebUIHandler* webui_handler) = 0;
@@ -285,7 +286,7 @@ class SigninScreenHandler
// LoginDisplayWebUIHandler implementation:
void ClearAndEnablePassword() override;
void ClearUserPodPassword() override;
- void OnUserRemoved(const std::string& username,
+ void OnUserRemoved(const AccountId& account_id,
bool last_user_removed) override;
void OnUserImageChanged(const user_manager::User& user) override;
void OnPreferencesChanged() override;

Powered by Google App Engine
This is Rietveld 408576698