chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc - Issue 1470633002: ChromeOS: Fix removeUser button on signin screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 1470633002: ChromeOS: Fix removeUser button on signin screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@462823--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Fix-GetKnownUserAccountId

Patch Set: Removed debug message. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc ('K') | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | components/user_manager/remove_user_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

index 73ee81e6f3ef2d59dc592d0cacc40c1fef700a1e..a1f1a7223b23bea666b926cc7d9d94c3c0e90a87 100644

--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

@@ -865,9 +865,9 @@ void SigninScreenHandler::RefocusCurrentPod() {

core_oobe_actor_->RefocusCurrentPod();

}

-void SigninScreenHandler::OnUserRemoved(const std::string& username,

+void SigninScreenHandler::OnUserRemoved(const AccountId& account_id,

bool last_user_removed) {

- CallJS("login.AccountPickerScreen.removeUser", username);

+ CallJS("login.AccountPickerScreen.removeUser", account_id);

if (last_user_removed)

OnShowAddUser();

}

@@ -1061,7 +1061,7 @@ void SigninScreenHandler::HandleRemoveUser(const AccountId& account_id) {

if (!delegate_)

return;

- delegate_->RemoveUser(account_id.GetUserEmail());

+ delegate_->RemoveUser(account_id);

UpdateAddButtonStatus();

}