chrome/browser/chromeos/login/signin_screen_controller.h - Issue 1470633002: ChromeOS: Fix removeUser button on signin screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin_screen_controller.h

Issue 1470633002: ChromeOS: Fix removeUser button on signin screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@462823--Chrome-OS-handles-deletion-of-Gmail-account-poorly--Fix-GetKnownUserAccountId

Patch Set: Removed debug message. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/signin/device_id_browsertest.cc ('k') | chrome/browser/chromeos/login/signin_screen_controller.cc » ('j') | chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin_screen_controller.h

diff --git a/chrome/browser/chromeos/login/signin_screen_controller.h b/chrome/browser/chromeos/login/signin_screen_controller.h

index e341062248af8dc113ffc9e088f586f94bc4befb..bce43a096d3dc5a3dc339cd12e8cfc1b9247e7ee 100644

--- a/chrome/browser/chromeos/login/signin_screen_controller.h

+++ b/chrome/browser/chromeos/login/signin_screen_controller.h

@@ -14,6 +14,8 @@

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

+class AccountId;

namespace chromeos {

class LoginDisplayWebUIHandler;

@@ -47,11 +49,11 @@ class SignInScreenController : public user_manager::RemoveUserDelegate,

// Query to remove user with specified id.

// TODO(antrim): move to user selection screen handler.

- void RemoveUser(const std::string& user_id);

+ void RemoveUser(const AccountId& account_id);

// user_manager::RemoveUserDelegate implementation:

achuithb 2015/11/23 21:17:39 could you make everything below here private while

Alexander Alekseev 2015/11/24 06:04:11 Hm. Do you think we should make overridden public

Alexander Alekseev 2015/11/24 06:58:00 Done.

- void OnBeforeUserRemoved(const std::string& username) override;

- void OnUserRemoved(const std::string& username) override;

+ void OnBeforeUserRemoved(const AccountId& account_id) override;

+ void OnUserRemoved(const AccountId& account_id) override;

// content::NotificationObserver implementation.

void Observe(int type,