Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1470623002: Update 'mb' setting for Linux ARM bots (Closed)

Created:
5 years, 1 month ago by Sam Clegg
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. - Remove now unused 'arm_float' settings. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG=159519 Committed: https://crrev.com/363fa3bc63c5a2caef16747eb8d003d45173d7f8 Cr-Commit-Position: refs/heads/master@{#361028}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M tools/mb/mb_config.pyl View 1 6 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Sam Clegg
5 years, 1 month ago (2015-11-21 00:31:29 UTC) #3
Dirk Pranke
lgtm w/ suggested change or equivalent. https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl#oldcode283 tools/mb/mb_config.pyl:283: }, actually, I'd ...
5 years, 1 month ago (2015-11-21 00:38:05 UTC) #7
Sam Clegg
https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl#oldcode283 tools/mb/mb_config.pyl:283: }, On 2015/11/21 00:38:05, Dirk Pranke wrote: > actually, ...
5 years, 1 month ago (2015-11-21 00:43:46 UTC) #8
Dirk Pranke
lgtm, thanks!
5 years, 1 month ago (2015-11-21 01:11:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470623002/20001
5 years, 1 month ago (2015-11-21 01:38:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/134161)
5 years, 1 month ago (2015-11-21 03:03:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470623002/20001
5 years, 1 month ago (2015-11-21 17:20:06 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 18:26:15 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 18:27:09 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/363fa3bc63c5a2caef16747eb8d003d45173d7f8
Cr-Commit-Position: refs/heads/master@{#361028}

Powered by Google App Engine
This is Rietveld 408576698