|
|
Created:
5 years, 1 month ago by Sam Clegg Modified:
5 years, 1 month ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate 'mb' setting for Linux ARM bots
- Add 'swarming' settings since these bots now use swarming.
- Remove 'arm_linux_tester' and corresponding 'none' settings.
- Remove now unused 'arm_float' settings.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=159519
Committed: https://crrev.com/363fa3bc63c5a2caef16747eb8d003d45173d7f8
Cr-Commit-Position: refs/heads/master@{#361028}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Update 'mb' setting for Linux ARM bots ========== to ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. ==========
sbc@chromium.org changed reviewers: + dpranke@chromium.org
Description was changed from ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. ========== to ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG= ==========
Description was changed from ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG= ========== to ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG=159519 ==========
Description was changed from ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG=159519 ========== to ========== Update 'mb' setting for Linux ARM bots - Add 'swarming' settings since these bots now use swarming. - Remove 'arm_linux_tester' and corresponding 'none' settings. - Remove now unused 'arm_float' settings. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile BUG=159519 ==========
lgtm w/ suggested change or equivalent. https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl#oldc... tools/mb/mb_config.pyl:283: }, actually, I'd like to leave this block in. Did the presubmit tests make you remove it? If so, I suggest we update a different bot like, say, "Linux Tests" on chromium.linux to use "none" instead of "swarming_gn_release_bot".
https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (left): https://codereview.chromium.org/1470623002/diff/1/tools/mb/mb_config.pyl#oldc... tools/mb/mb_config.pyl:283: }, On 2015/11/21 00:38:05, Dirk Pranke wrote: > actually, I'd like to leave this block in. Did the presubmit tests make you > remove it? > > If so, I suggest we update a different bot like, say, "Linux Tests" on > chromium.linux > to use "none" instead of "swarming_gn_release_bot". Yes, presubmit told me to do it. Done.
lgtm, thanks!
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470623002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/363fa3bc63c5a2caef16747eb8d003d45173d7f8 Cr-Commit-Position: refs/heads/master@{#361028} |