Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1470613003: [Contextual Search] Fix positioning of RTL promo. (Closed)

Created:
5 years, 1 month ago by pedro (no code reviews)
Modified:
5 years, 1 month ago
Reviewers:
Donn Denman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Fix positioning of RTL promo. BUG=557739 Committed: https://crrev.com/ffad6ad15807b34f21bd25687e1e90b18602200b Cr-Commit-Position: refs/heads/master@{#361161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
pedro (no code reviews)
Donn, please take a look.
5 years, 1 month ago (2015-11-21 00:46:13 UTC) #3
Donn Denman
lgtm
5 years, 1 month ago (2015-11-21 00:57:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470613003/1
5 years, 1 month ago (2015-11-23 18:55:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 20:14:29 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 20:16:06 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ffad6ad15807b34f21bd25687e1e90b18602200b
Cr-Commit-Position: refs/heads/master@{#361161}

Powered by Google App Engine
This is Rietveld 408576698