Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 14706011: Revert 150468 "Switching CSS Variables over to RuntimeEnabledFea..." (Closed)

Created:
7 years, 7 months ago by eseidel
Modified:
7 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert 150468 "Switching CSS Variables over to RuntimeEnabledFea..." fast/css/parsing-expr-error-recovery.html appears to hit an ASSERT in debug. This is the only change on the blame-list. > Switching CSS Variables over to RuntimeEnabledFeatures > > Taking the CSS Variables flag out of InternalSettings and Settings > and using RuntimeEnabledFeatures instead. > > > BUG=239748 > > Review URL: https://chromiumcodereview.appspot.com/14987004 TBR=alancutter@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -6 lines) Patch
MM trunk/LayoutTests/css3/filters/reference-filter-update-after-remove.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/border-width.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/build-supports-variables.html View 1 chunk +2 lines, -1 line 0 comments Download
MM trunk/LayoutTests/fast/css/variables/calc.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/calc-inside-calc.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/calc-invalid-value.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/calc-invalid-variable.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/calc-negated-variable.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/calc-vw-crash.html View 1 chunk +1 line, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/case-insensitive.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/colors-test.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/complex-cycle.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/computed-style.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/deferred-image-load-from-variable.html View 1 chunk +1 line, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/inherited-values.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/inline-styles.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/invalid-font-reference.html View 1 chunk +1 line, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/invalid-shorthand.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/invalid-value-list-crash.html View 1 chunk +1 line, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/invalid-variable-value.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/multi-level-cycle.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/redefinition.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/root-background-size.html View 1 chunk +4 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/shorthand.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/simple-cycle.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/transform-test.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/undefined.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/use-before-defined.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/var-filter.html View 1 chunk +1 line, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/var-inside-box-reflect.html View 1 chunk +4 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/var-inside-pair.html View 1 chunk +4 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/var-inside-quad.html View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/LayoutTests/fast/css/variables/var-inside-shape.html View 1 chunk +4 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/var-inside-shorthand.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/variable-chain.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/fast/css/variables/variable-unparseable-value-crash.html View 1 chunk +1 line, -0 lines 0 comments Download
MM trunk/LayoutTests/inspector/styles/variables/css-variables.html View 1 chunk +3 lines, -0 lines 0 comments Download
MM trunk/LayoutTests/inspector/styles/variables/css-variables-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/WebKit/chromium/public/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/WebKit/chromium/src/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M trunk/Source/core/css/CSSParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/core/css/CSSParser.cpp View 6 chunks +10 lines, -2 lines 0 comments Download
M trunk/Source/core/css/CSSParserMode.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/core/page/Settings.h View 2 chunks +4 lines, -0 lines 0 comments Download
M trunk/Source/core/page/Settings.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/Source/core/testing/InternalSettings.h View 2 chunks +5 lines, -0 lines 0 comments Download
M trunk/Source/core/testing/InternalSettings.cpp View 3 chunks +14 lines, -0 lines 0 comments Download
M trunk/Source/core/testing/InternalSettings.idl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eseidel
7 years, 7 months ago (2013-05-16 05:26:40 UTC) #1
eseidel
7 years, 7 months ago (2013-05-16 06:28:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r150491.

Powered by Google App Engine
This is Rietveld 408576698