Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: chrome/browser/prefs/tracked/tracked_preference_helper.h

Issue 147053005: Coarser levels for the SettingsEnforcement field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: constantify trial/group names Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/tracked_preference_helper.h
diff --git a/chrome/browser/prefs/tracked/tracked_preference_helper.h b/chrome/browser/prefs/tracked/tracked_preference_helper.h
index a9d992f57dbaf86d0ba7c1d7fce7f857ee18265c..c0c3f7473e7202972961d2741e6101b65d6ecaf2 100644
--- a/chrome/browser/prefs/tracked/tracked_preference_helper.h
+++ b/chrome/browser/prefs/tracked/tracked_preference_helper.h
@@ -29,10 +29,10 @@ class TrackedPreferenceHelper {
size_t reporting_ids_count,
PrefHashFilter::EnforcementLevel enforcement_level);
- // Returns a ResetAction stating whether a reset is desired (DO_RESET) based
- // on observing |value_state| or not (DONT_RESET). |allow_changes_|,
- // |allow_seeding_|, and |allow_migration_| make the decision softer in favor
- // of WANTED_RESET over DO_RESET in various scenarios.
+ // Returns a ResetAction stating whether a reset is desired (DO_RESET) or not
+ // (DONT_RESET) based on observing |value_state|. Can also return WANTED_RESET
+ // if a reset would have been desired but the current |enforcement_level|
+ // doesn't allow it.
ResetAction GetAction(
PrefHashStoreTransaction::ValueState value_state) const;
@@ -53,12 +53,8 @@ class TrackedPreferenceHelper {
const size_t reporting_id_;
const size_t reporting_ids_count_;
- // Allow setting changes.
- const bool allow_changes_;
- // Allow seeding unknown values for atomic preferences.
- const bool allow_seeding_;
- // Allow migration of values validated by the old MAC algorithm.
- const bool allow_migration_;
+ // Deny setting changes and hash seeding/migration.
+ const bool enforce_;
DISALLOW_COPY_AND_ASSIGN(TrackedPreferenceHelper);
};
« no previous file with comments | « chrome/browser/prefs/pref_hash_filter_unittest.cc ('k') | chrome/browser/prefs/tracked/tracked_preference_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698