Coarser levels for the SettingsEnforcement field trial.

Coarser levels for the SettingsEnforcement field trial.

Also constantifying trial/group names for that trial to avoid duplicating hard-coded strings.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250928

[gab, 2014-02-11 20:33:50]

Robert, as discussed, PTAL.

@Alexei: is it sane to change the name of groups in a field trial? This field
trial is still only in no_enforcement @ 100%.

[robertshield, 2014-02-11 21:16:39]

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:152: GROUP_ENFORCE_ALWAYS
Comments re. what these mean plz.

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:163: { "enforce_always",
GROUP_ENFORCE_ALWAYS },
GROUP_ENFORCE_ALWAYS isn't currently used, tell me again why we need it in this
CL?

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:260:
PrefHashFilter::NO_ENFORCEMENT : PrefHashFilter::ENFORCE_ON_LOAD;
Can this still live in a GetSettingsEnforcementLevel function? I kind of liked
having all the logic for the enforcement level computation in one place.

[gab, 2014-02-11 21:25:57]

Thanks, PTAL.

+CC: erikwright

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
File chrome/browser/prefs/chrome_pref_service_factory.cc (right):

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:152: GROUP_ENFORCE_ALWAYS
On 2014/02/11 21:16:40, robertshield wrote:
> Comments re. what these mean plz.

Done.

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:163: { "enforce_always",
GROUP_ENFORCE_ALWAYS },
On 2014/02/11 21:16:40, robertshield wrote:
> GROUP_ENFORCE_ALWAYS isn't currently used, tell me again why we need it in
this
> CL?

Added TODO above.

https://codereview.chromium.org/147053005/diff/30001/chrome/browser/prefs/chr...
chrome/browser/prefs/chrome_pref_service_factory.cc:260:
PrefHashFilter::NO_ENFORCEMENT : PrefHashFilter::ENFORCE_ON_LOAD;
On 2014/02/11 21:16:40, robertshield wrote:
> Can this still live in a GetSettingsEnforcementLevel function? I kind of liked
> having all the logic for the enforcement level computation in one place.

No; GROUP_ENFORCE_ALWAYS means to not do unloaded profile initialization (which
is not a concept PrefHashFilter knows about); that group will be handled in this
file only.

[Alexei Svitkine (slow), 2014-02-11 21:36:26]

Changing field trial group names should be fine. lgtm

[gab, 2014-02-12 19:24:15]

Erik/Robert PTAL; added constants for the trial/group names after realizing I'd
forget to update dependent tests...

Cheers,
Gab

[robertshield, 2014-02-13 00:35:57]

lgtm

Code and change lgtm.

[commit-bot: I haz the power, 2014-02-13 00:37:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/147053005/260001

[commit-bot: I haz the power, 2014-02-13 03:50:07]

Change committed as 250928