Chromium Code Reviews

Issue 14705010: Add test case that documents all global constructors (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
Reviewers:
haraken, eseidel, arv (Not doing code reviews), jochen (gone - plz use gerrit), abarth-chromium
CC:
blink-reviews, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add test case that documents all global constructors This test cases prints the name of all global constructors so that we can better highlight changes in those. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149850

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+473 lines, -0 lines)
A LayoutTests/fast/dom/global-constructors-listing.html View 1 chunk +27 lines, -0 lines 0 comments
A LayoutTests/fast/dom/global-constructors-listing-expected.txt View 1 chunk +446 lines, -0 lines 0 comments

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-07 04:30:26 UTC) #1
haraken
LGTM
7 years, 7 months ago (2013-05-07 04:37:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14705010/1
7 years, 7 months ago (2013-05-07 05:06:11 UTC) #3
commit-bot: I haz the power
Change committed as 149850
7 years, 7 months ago (2013-05-07 06:01:39 UTC) #4
eseidel
If you move this to webexposed/ then it will also be tested against the stable ...
7 years, 7 months ago (2013-05-07 06:03:46 UTC) #5
do-not-use
7 years, 7 months ago (2013-05-07 06:17:24 UTC) #6
Message was sent while issue was closed.
On 2013/05/07 06:03:46, Eric Seidel (Google) wrote:
> If you move this to webexposed/ then it will also be tested against the stable
> configuration once we switch to Content Shell. :)

Good to know. I will file a new CL to move the test, thanks.

Powered by Google App Engine