Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14705009: Remove RangeException interface (Closed)

Created:
7 years, 7 months ago by arv (Not doing code reviews)
Modified:
7 years, 7 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Remove RangeException interface The RangeException idl interface is not part of any standard. It was used for a few range related operations. The spec says that these should use DOMException instead. BUG=229397 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149737

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Update expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -243 lines) Patch
D LayoutTests/fast/dom/DOMException/RangeException.html View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/DOMException/RangeException-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/DOMException/resources/RangeException.js View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/fast/dom/Range/range-compareNode.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/range-exceptions-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Range/range-intersectsNode-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Range/script-tests/range-exceptions.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/resources/wrapper-identity-base.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-identity-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium-android/fast/dom/Window/window-lookup-precedence-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/dom/DOMExceptions.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 10 chunks +10 lines, -11 lines 0 comments Download
D Source/core/dom/RangeException.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/dom/RangeException.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
D Source/core/dom/RangeException.idl View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/core/page/DOMWindow.idl View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
arv (Not doing code reviews)
7 years, 7 months ago (2013-05-03 20:11:06 UTC) #1
eseidel
lgtm
7 years, 7 months ago (2013-05-04 01:27:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:28:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:28:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:30:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:30:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:30:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:30:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:31:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:31:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-04 01:31:42 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=3901
7 years, 7 months ago (2013-05-04 03:55:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/arv@chromium.org/14705009/5001
7 years, 7 months ago (2013-05-06 15:34:46 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 16:07:40 UTC) #14
Message was sent while issue was closed. 
Change committed as 149737

Powered by Google App Engine
This is Rietveld 408576698