Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: cc/output/shader_unittest.cc

Issue 14705008: cc: Cache highp_threshold in TexCoordPrecisionRequired (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Use local cache rather than global cache to avoid thread hazards. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/shader_unittest.cc
diff --git a/cc/output/shader_unittest.cc b/cc/output/shader_unittest.cc
index adbe887113f1d6404f3a49b9f7792efe0c830686..fceb90872d18451d5a40d962dd6bf26c9563679b 100644
--- a/cc/output/shader_unittest.cc
+++ b/cc/output/shader_unittest.cc
@@ -16,6 +16,7 @@ TEST(ShaderTest, HighpThresholds) {
// which corresponds to a native highp threshold of 2^10 = 1024
FakeWebGraphicsContext3D context;
+ int threshold_cache = 0;
int threshold_min;
gfx::Point closePoint(512, 512);
gfx::Size smallSize(512, 512);
@@ -23,24 +24,23 @@ TEST(ShaderTest, HighpThresholds) {
gfx::Size bigSize(2560, 2560);
threshold_min = 0;
- EXPECT_EQ(TexCoordPrecisionMedium,
- TexCoordPrecisionRequired(&context, threshold_min, closePoint));
- EXPECT_EQ(TexCoordPrecisionMedium,
- TexCoordPrecisionRequired(&context, threshold_min, smallSize));
- EXPECT_EQ(TexCoordPrecisionHigh,
- TexCoordPrecisionRequired(&context, threshold_min, farPoint));
- EXPECT_EQ(TexCoordPrecisionHigh,
- TexCoordPrecisionRequired(&context, threshold_min, bigSize));
+ EXPECT_EQ(TexCoordPrecisionMedium, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, closePoint));
+ EXPECT_EQ(TexCoordPrecisionMedium, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, smallSize));
+ EXPECT_EQ(TexCoordPrecisionHigh, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, farPoint));
+ EXPECT_EQ(TexCoordPrecisionHigh, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, bigSize));
threshold_min = 3000;
- EXPECT_EQ(TexCoordPrecisionMedium,
- TexCoordPrecisionRequired(&context, threshold_min, closePoint));
- EXPECT_EQ(TexCoordPrecisionMedium,
- TexCoordPrecisionRequired(&context, threshold_min, smallSize));
- EXPECT_EQ(TexCoordPrecisionMedium,
- TexCoordPrecisionRequired(&context, threshold_min, farPoint));
- EXPECT_EQ(TexCoordPrecisionMedium,
- TexCoordPrecisionRequired(&context, threshold_min, bigSize));
+ EXPECT_EQ(TexCoordPrecisionMedium, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, closePoint));
+ EXPECT_EQ(TexCoordPrecisionMedium, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, smallSize));
+ EXPECT_EQ(TexCoordPrecisionMedium, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, farPoint));
+ EXPECT_EQ(TexCoordPrecisionMedium, TexCoordPrecisionRequired(
+ &context, &threshold_cache, threshold_min, bigSize));
}
-
}
« cc/output/shader.cc ('K') | « cc/output/shader.cc ('k') | cc/output/texture_copier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698