win gn: Use /safeseh, not /SAFESEH

win gn: Use /safeseh, not /SAFESEH

[14421->5901/20355 ~33] ASM obj/third_party/crashpad/crashpad/util/util/capture_context.obj
MASM : warning A4018:invalid command-line option : /SAFESEH
MASM : warning A4018:invalid command-line option : /SFESEH
MASM : warning A4018:invalid command-line option : /SESEH
MASM : warning A4018:invalid command-line option : /SSEH
MASM : warning A4018:invalid command-line option : /SEH
MASM : warning A4018:invalid command-line option : /SH

BUG=546288
R=brettw@chromium.org

Committed: https://crrev.com/7ba9b478144998dc08029cddf61e8a48745fef9a
Cr-Commit-Position: refs/heads/master@{#360960}

[brettw, 2015-11-20 21:36:28]

lgtm

[scottmg, 2015-11-20 21:38:19]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-11-20 21:38:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470483002/20001

[commit-bot: I haz the power, 2015-11-20 22:43:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 22:43:00]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottmg, 2015-11-20 23:27:10]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-11-20 23:28:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470483002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470483002/20001

[commit-bot: I haz the power, 2015-11-21 00:26:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-21 00:27:45]

Patchset 2 (id:??) landed as
https://crrev.com/7ba9b478144998dc08029cddf61e8a48745fef9a
Cr-Commit-Position: refs/heads/master@{#360960}

[brucedawson, 2015-11-25 19:16:54]

On 2015/11/21 00:27:45, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/7ba9b478144998dc08029cddf61e8a48745fef9a
> Cr-Commit-Position: refs/heads/master@{#360960}

It's too late now, but your comment is arguably wrong. According to ml /? and
link /? the correct spelling is /safeseh for ml and /SAFESEH for the linker. So
in the sentence fragment below it should be /SAFESEH because you're talking
about the linker:

    "When /safeseh is specified, the linker"...

Then again, the linker is probably case insensitive because it's actually got a
team working on it.

Also, note that ml64 does not accept the /safeseh option - it is on
automatically and specifying /safeseh will give a warning.

[scottmg, 2015-11-25 19:26:27]

On 2015/11/25 19:16:54, brucedawson wrote:
> On 2015/11/21 00:27:45, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/7ba9b478144998dc08029cddf61e8a48745fef9a
> > Cr-Commit-Position: refs/heads/master@{#360960}
> 
> It's too late now, but your comment is arguably wrong. According to ml /? and
> link /? the correct spelling is /safeseh for ml and /SAFESEH for the linker.
So
> in the sentence fragment below it should be /SAFESEH because you're talking
> about the linker:
> 
>     "When /safeseh is specified, the linker"...

Yeah, I just search/replaced, but what we should probably do is move this
comment down the to linker section (and then switch it back to /SAFESEH down
there).

I think the ml one is case sensitive because there's a bunch of /Sxyz options.

> 
> Then again, the linker is probably case insensitive because it's actually got
a
> team working on it.
> 
> Also, note that ml64 does not accept the /safeseh option - it is on
> automatically and specifying /safeseh will give a warning.

Is /safeseh being applied to ml64 right now? We should definitely fix that. I
haven't switched to GN for daily work yet.