Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java

Issue 14704011: Report CompileTimeErrorCode.MEMBER_WITH_CLASS_NAME (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
index 2ba64afc8e59e6ec1c79a7694769863cd505ef4c..386cb25c0b81ea046fcb5b8fce0bd4155f25ece8 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java
@@ -272,16 +272,6 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
verify(source);
}
- public void fail_memberWithClassName() throws Exception { // field, getter, setter, method
- Source source = addSource(createSource(//
- "class A {",
- " int A = 0;",
- "}"));
- resolve(source);
- assertErrors(CompileTimeErrorCode.MEMBER_WITH_CLASS_NAME);
- verify(source);
- }
-
public void fail_mixinDeclaresConstructor() throws Exception {
Source source = addSource(createSource(//
"class A {",
@@ -1710,6 +1700,40 @@ public class CompileTimeErrorCodeTest extends ResolverTestCase {
// We cannot verify resolution with undefined labels
}
+ public void test_memberWithClassName_field() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " int A = 0;",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.MEMBER_WITH_CLASS_NAME);
+ verify(source);
+ }
+
+ public void test_memberWithClassName_field2() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " int z, A, b = 0;",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.MEMBER_WITH_CLASS_NAME);
+ verify(source);
+ }
+
+ public void test_memberWithClassName_getter() throws Exception {
+ Source source = addSource(createSource(//
+ "class A {",
+ " get A() => 0;",
+ "}"));
+ resolve(source);
+ assertErrors(CompileTimeErrorCode.MEMBER_WITH_CLASS_NAME);
+ verify(source);
+ }
+
+ public void test_memberWithClassName_method() throws Exception {
+ // no test because indistinguishable from constructor
+ }
+
public void test_mixinOfNonClass_class() throws Exception {
Source source = addSource(createSource(//
"int A;",

Powered by Google App Engine
This is Rietveld 408576698