Issue 14704005: UDP transient errors should not be fatal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14704005: UDP transient errors should not be fatal (Closed)

Created:
7 years, 7 months ago by Alpha Left Google

Modified:
7 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

UDP transient errors should not be fatal These two errors are not fatal: net::ERR_OUT_OF_MEMORY This is caused by ENOBUFS which means the buffer of the network interface is full net::ERR_CONNECTION_RESET This is caused by WSAENETRESET or WSAECONNRESET which means the last send resulted in an ICMP Port Unreachable message. BUG=237413 R=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197822

Patch Set 1 #

Patch Set 2 : done #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	content/browser/renderer_host/p2p/socket_host_udp.cc	View	1	1 chunk	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

Please copy comments from CL description to the code. LGTM otherwise.

7 years, 7 months ago (2013-05-02 02:08:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/14704005/4001

7 years, 7 months ago (2013-05-02 02:13:18 UTC) #4

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=35884

7 years, 7 months ago (2013-05-02 05:05:00 UTC) #5

Alpha Left Google

7 years, 7 months ago (2013-05-02 05:24:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r197822 (presubmit successful).

Expand Messages | Collapse Messages