Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 1470373005: Revert "Revert of [Discardable Shared Memory] Adding Windows support. (patchset #5 id:80001 of http… (Closed)

Created:
5 years ago by pennymac
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of [Discardable Shared Memory] Adding Windows support. (patchset #5 id:80001 of https://codereview.chromium.org/1427163003/ )" This reverts commit d4bd2aafb9eb736fa1cf3844cb389c30d91aa7db. Regression is known and accepted. My bad for forgetting to close off the perf ticket appropriately. BUG=555225, 180334 Committed: https://chromium.googlesource.com/chromium/src/+/2e0a429d58f8ee480e61aa6cb184a7dde1f0d952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M base/memory/discardable_shared_memory.cc View 7 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e0a429d58f8ee480e61aa6cb184a7dde1f0d952 Cr-Commit-Position: refs/heads/master@{#361777}
5 years ago (2015-11-26 00:58:33 UTC) #2
pennymac
5 years ago (2015-11-26 00:59:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e0a429d58f8ee480e61aa6cb184a7dde1f0d952.

Powered by Google App Engine
This is Rietveld 408576698