[css-flexbox] Correctly implement flex factors < 1

[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752, 549993
R=leviw@chromium.org

Committed: https://crrev.com/36921b28f83a30d8d0caaa408b1586afed2ca323
Cr-Commit-Position: refs/heads/master@{#361808}

[cbiesinger, 2015-11-25 03:11:31]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 03:13:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470373003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470373003/1

[commit-bot: I haz the power, 2015-11-25 04:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 04:51:31]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2015-11-25 17:01:03]

Actually, this isn't quite correct, let me work on this a little more...

[cbiesinger, 2015-11-25 17:01:22]

Description was changed from

==========
[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752
R=leviw@chromium.org
==========

to

==========
[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752,549993
R=leviw@chromium.org
==========

[cbiesinger, 2015-11-25 18:17:06]

On 2015/11/25 17:01:03, cbiesinger wrote:
> Actually, this isn't quite correct, let me work on this a little more...

OK, Levi, can you take a look now? Thanks!

[cbiesinger, 2015-11-25 18:17:11]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 18:18:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470373003/20001

[leviw_travelin_and_unemployed, 2015-11-25 19:00:22]

https://codereview.chromium.org/1470373003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h (right):

https://codereview.chromium.org/1470373003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h:160: bool
resolveFlexibleLengths(FlexSign, const OrderedFlexItemList&, LayoutUnit
availableFreeSpace, LayoutUnit& remainingFreeSpace, double& totalFlexGrow,
double& totalFlexShrink, double& totalWeightedFlexShrink,
InflexibleFlexItemSize&, Vector<LayoutUnit, 16>& childSizes);
I can follow the code and it looks good, but I feel like the distinction between
remainingFreeSpace and availableFreeSpace could use a brief comment.

[commit-bot: I haz the power, 2015-11-25 19:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 19:45:24]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2015-11-25 23:19:10]

https://codereview.chromium.org/1470373003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h (right):

https://codereview.chromium.org/1470373003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h:160: bool
resolveFlexibleLengths(FlexSign, const OrderedFlexItemList&, LayoutUnit
availableFreeSpace, LayoutUnit& remainingFreeSpace, double& totalFlexGrow,
double& totalFlexShrink, double& totalWeightedFlexShrink,
InflexibleFlexItemSize&, Vector<LayoutUnit, 16>& childSizes);
On 2015/11/25 19:00:22, leviw wrote:
> I can follow the code and it looks good, but I feel like the distinction
between
> remainingFreeSpace and availableFreeSpace could use a brief comment.

I added a comment in the calling function. Does that look good to you now?

[leviw_travelin_and_unemployed, 2015-11-26 00:18:15]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-11-26 00:18:15]

lgtm

Much better! :)

[commit-bot: I haz the power, 2015-11-26 00:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470373003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470373003/40001

[commit-bot: I haz the power, 2015-11-26 02:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 02:24:43]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[cbiesinger, 2015-11-26 02:26:49]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2015-11-26 02:27:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470373003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470373003/40001

[commit-bot: I haz the power, 2015-11-26 03:54:24]

Description was changed from

==========
[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752,549993
R=leviw@chromium.org
==========

to

==========
[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752,549993
R=leviw@chromium.org
==========

[commit-bot: I haz the power, 2015-11-26 03:54:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-26 03:55:31]

Description was changed from

==========
[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752,549993
R=leviw@chromium.org
==========

to

==========
[css-flexbox] Correctly implement flex factors < 1

When the sum of flex factors is < 1, we need to multiply the available
space by that. We currently do this in a slightly different way that's
mostly-correct for flex-grow, but doesn't do anything for flex-shrink.

This patch fixes that.

BUG=480752,549993
R=leviw@chromium.org

Committed: https://crrev.com/36921b28f83a30d8d0caaa408b1586afed2ca323
Cr-Commit-Position: refs/heads/master@{#361808}
==========

[commit-bot: I haz the power, 2015-11-26 03:55:32]

Patchset 3 (id:??) landed as
https://crrev.com/36921b28f83a30d8d0caaa408b1586afed2ca323
Cr-Commit-Position: refs/heads/master@{#361808}