Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1470353002: Treat WASM_FUNCTION frames as stubs. (Closed)

Created:
5 years ago by titzer
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Treat WASM_FUNCTION frames as stubs. This is "more correct" than WASM_FUNCTION falling through the switch over code types and using the marker on the stack which contains a bogus value. In the long run, there will be two kinds of WASM-related frames: frames that cross the JS/WASM border, and internal WASM_FUNCTION frames. This will necessitate a new StackFrame::Type, since the first kind of frame must treat its parameters as tagged values and the second definitely should not. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/2c37146bfaeafcacaf549a013fa9ab0519db3bf9 Cr-Commit-Position: refs/heads/master@{#32256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/frames.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years ago (2015-11-24 19:34:50 UTC) #1
Michael Starzinger
LGTM if the stack-walks still work for you.
5 years ago (2015-11-25 09:22:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470353002/1
5 years ago (2015-11-25 09:32:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 09:33:32 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 09:33:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c37146bfaeafcacaf549a013fa9ab0519db3bf9
Cr-Commit-Position: refs/heads/master@{#32256}

Powered by Google App Engine
This is Rietveld 408576698