Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1470333002: Revert of Move --harmony-destructuring-bind to shipping (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Move --harmony-destructuring-bind to shipping (patchset #5 id:80001 of https://codereview.chromium.org/1451843002/ ) Reason for revert: Fails on V8 Fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/6028 Original issue's description: > Move --harmony-destructuring-bind to shipping > > Also fix CheckConflictingVarDeclarations() to properly handle > legacy const bindings. Without that change enabling the flag > causes code like: > > function f() { const x; var x; } > > to throw an early error, rather than wait to throw the error > until f is invoked. > > BUG=v8:811 > LOG=y > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/515093630a4a925a66d550561e38293d49633f10 > Cr-Commit-Position: refs/heads/master@{#32222} TBR=rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Committed: https://crrev.com/d756c65382e3bfa1db6b5e6005d085456e6301f9 Cr-Commit-Position: refs/heads/master@{#32226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M src/scopes.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of Move --harmony-destructuring-bind to shipping
5 years ago (2015-11-24 18:58:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470333002/1
5 years ago (2015-11-24 18:58:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 18:58:58 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-24 18:59:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d756c65382e3bfa1db6b5e6005d085456e6301f9
Cr-Commit-Position: refs/heads/master@{#32226}

Powered by Google App Engine
This is Rietveld 408576698