Move some non-unittest files to compositor_test_support

Move some non-unittest files to compositor_test_support


BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247903

[bshe, 2014-01-28 16:47:50]

Hi Sadrul and Dana.

Do you guys mind to take a look at this CL? Thanks!

[sadrul, 2014-01-28 16:50:07]

Do you need to COMPOSITOR_EXPORT LayerAnimatorTestController?

[danakj, 2014-01-28 16:50:21]

https://codereview.chromium.org/147033003/diff/1/ui/compositor/compositor.gyp
File ui/compositor/compositor.gyp (right):

https://codereview.chromium.org/147033003/diff/1/ui/compositor/compositor.gyp...
ui/compositor/compositor.gyp:128: 'test/test_compositor_host.h',
How about moving all these files that aren't unit tests into the test support?

[bshe, 2014-01-28 17:45:01]

Thanks for review.

It looks like the compositor_test_support is a static library. So the
COMPOSITOR_EXPORT is probably not necessary right now.

https://codereview.chromium.org/147033003/diff/1/ui/compositor/compositor.gyp
File ui/compositor/compositor.gyp (right):

https://codereview.chromium.org/147033003/diff/1/ui/compositor/compositor.gyp...
ui/compositor/compositor.gyp:128: 'test/test_compositor_host.h',
On 2014/01/28 16:50:22, danakj wrote:
> How about moving all these files that aren't unit tests into the test support?

Done.

[danakj, 2014-01-28 17:48:06]

Thanks, LGTM

[sadrul, 2014-01-28 18:40:13]

On 2014/01/28 17:45:01, bshe wrote:
> Thanks for review.
> 
> It looks like the compositor_test_support is a static library. So the
> COMPOSITOR_EXPORT is probably not necessary right now.

Cool. LGTM

[commit-bot: I haz the power, 2014-01-28 18:43:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/147033003/60001

[commit-bot: I haz the power, 2014-01-28 21:33:07]

Retried try job too often on mac_rel for step(s) app_list_unittests,
base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chromedriver_unittests, components_unittests,
content_browsertests, content_unittests, crypto_unittests,
google_apis_unittests, gpu_unittests, interactive_ui_tests, ipc_tests,
jingle_unittests, media_unittests, message_center_unittests, nacl_integration,
net_unittests, ppapi_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests,
telemetry_perf_unittests, telemetry_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 15:03:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/147033003/120001

[commit-bot: I haz the power, 2014-01-29 16:05:45]

Retried try job too often on mac_rel for step(s) app_list_unittests,
base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chromedriver_unittests, components_unittests,
content_browsertests, content_unittests, crypto_unittests,
google_apis_unittests, gpu_unittests, interactive_ui_tests, ipc_tests,
jingle_unittests, media_unittests, message_center_unittests, nacl_integration,
net_unittests, ppapi_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests,
telemetry_perf_unittests, telemetry_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2014-01-29 20:40:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/147033003/160001

[commit-bot: I haz the power, 2014-01-30 08:48:16]

Change committed as 247903