Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Issue 147033002: Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat. (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat. (https://codereview.chromium.org/146823002/) Reason for revert: This will break many Chromium tests when we roll. Original issue's description: > Use SkMScalar as intermediates in SkMatrix44::setConcat. > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=13167 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/utils/SkMatrix44.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Use SkMScalar as intermediates in SkMatrix44::setConcat.
6 years, 11 months ago (2014-01-24 18:47:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/147033002/1
6 years, 11 months ago (2014-01-24 18:47:53 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 18:48:04 UTC) #3
Message was sent while issue was closed.
Change committed as 13173

Powered by Google App Engine
This is Rietveld 408576698