Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: chrome/renderer/js_only_v8_extensions.cc

Issue 147033: Refactor extension bindings to share code, avoid exposing hidden variables (Closed)
Patch Set: at head Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/js_only_v8_extensions.h" 5 #include "chrome/renderer/js_only_v8_extensions.h"
6 6
7 #include "chrome/renderer/extensions/bindings_utils.h" 7 #include "chrome/renderer/extensions/bindings_utils.h"
8 #include "grit/renderer_resources.h" 8 #include "grit/renderer_resources.h"
9 #include "grit/webkit_resources.h" 9 #include "grit/webkit_resources.h"
10 10
11 using bindings_utils::GetStringResource;
12
11 // BaseJsV8Extension 13 // BaseJsV8Extension
12 const char* BaseJsV8Extension::kName = "chrome/base"; 14 const char* BaseJsV8Extension::kName = "chrome/base";
13 v8::Extension* BaseJsV8Extension::Get() { 15 v8::Extension* BaseJsV8Extension::Get() {
14 return new v8::Extension(kName, GetStringResource<IDR_DEVTOOLS_BASE_JS>(), 16 return new v8::Extension(kName, GetStringResource<IDR_DEVTOOLS_BASE_JS>(),
15 0, NULL); 17 0, NULL);
16 } 18 }
17 19
18 // JsonSchemaJsV8Extension 20 // JsonSchemaJsV8Extension
19 const char* JsonSchemaJsV8Extension::kName = "chrome/jsonschema"; 21 const char* JsonSchemaJsV8Extension::kName = "chrome/jsonschema";
20 v8::Extension* JsonSchemaJsV8Extension::Get() { 22 v8::Extension* JsonSchemaJsV8Extension::Get() {
21 return new v8::Extension(kName, GetStringResource<IDR_JSON_SCHEMA_JS>(), 23 return new v8::Extension(kName, GetStringResource<IDR_JSON_SCHEMA_JS>(),
22 0, NULL); 24 0, NULL);
23 } 25 }
OLDNEW
« no previous file with comments | « chrome/renderer/extensions/renderer_extension_bindings.cc ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698