Refactor extension bindings to share code, avoid exposing hidden variables

chrome/browser/extensions/extension_message_service.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_message_service.h"
 
 #include "base/json_writer.h"
 #include "base/singleton.h"
 #include "base/stl_util-inl.h"
 #include "base/values.h"
@@ skipping 71 matching lines @@
 
 // Since ExtensionMessageService is a collection of Singletons, we don't need to
 // grab a reference to it when creating Tasks involving it.
 template <> struct RunnableMethodTraits<ExtensionMessageService> {
   static void RetainCallee(ExtensionMessageService*) {}
   static void ReleaseCallee(ExtensionMessageService*) {}
 };
 
 
 const char ExtensionMessageService::kDispatchOnConnect[] =
-    "chrome.Port.dispatchOnConnect_";
+    "Port.dispatchOnConnect";
 const char ExtensionMessageService::kDispatchOnDisconnect[] =
-    "chrome.Port.dispatchOnDisconnect_";
+    "Port.dispatchOnDisconnect";
 const char ExtensionMessageService::kDispatchOnMessage[] =
-    "chrome.Port.dispatchOnMessage_";
+    "Port.dispatchOnMessage";
 const char ExtensionMessageService::kDispatchEvent[] =
-    "chrome.Event.dispatchJSON_";
+    "Event.dispatchJSON";
 
 // static
 ExtensionMessageService* ExtensionMessageService::GetInstance(
     URLRequestContext* context) {
   SingletonData* data = Singleton<SingletonData>::get();
   AutoLock lock(data->lock);
 
   ExtensionMessageService* instance = data->map[context];
   if (!instance) {
     instance = new ExtensionMessageService();
@@ skipping 259 matching lines @@
       DispatchOnDisconnect(current->second.port2,
                            GET_CHANNEL_PORT1(current->first));
       channels_.erase(current);
     } else if (current->second.port2 == renderer) {
       DispatchOnDisconnect(current->second.port1,
                            GET_CHANNEL_PORT2(current->first));
       channels_.erase(current);
     }
   }
 }