Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 1470323003: [DevTools] Removed support deprecated (//@|/*@) source(URL|MappingURL)= (Closed)

Created:
5 years ago by kozy
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Removed support deprecated (//@|/*@) source(URL|MappingURL)= BUG=558998 R=pfeldman@chromium.org Committed: https://crrev.com/db38f0f9b20d50863d9520294065b7307aa633e7 Cr-Commit-Position: refs/heads/master@{#362871}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -95 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/resources/selector-line-deprecated.css View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-objects-tracking.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-samples-in-snapshot.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/stylesheet-source-url-comment.html View 2 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/stylesheet-source-url-comment-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/ManualTests/inspector/bp-in-named-eval-after-reload.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/ManualTests/inspector/hidden-evals.html View 6 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/ManualTests/inspector/named-evals.html View 3 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/ManualTests/inspector/remember-last-script.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ContentSearchUtils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ContentSearchUtils.cpp View 4 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (9 generated)
pfeldman
lgtm
5 years ago (2015-11-25 01:40:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470323003/20001
5 years ago (2015-12-02 18:28:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/148944)
5 years ago (2015-12-02 20:19:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470323003/20001
5 years ago (2015-12-02 20:31:00 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/149115)
5 years ago (2015-12-02 22:19:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470323003/20001
5 years ago (2015-12-02 22:28:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/149256)
5 years ago (2015-12-03 01:01:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470323003/20001
5 years ago (2015-12-03 01:15:54 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 02:35:11 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-03 02:36:11 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db38f0f9b20d50863d9520294065b7307aa633e7
Cr-Commit-Position: refs/heads/master@{#362871}

Powered by Google App Engine
This is Rietveld 408576698