Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 14703009: Fix bug when optimized code map is evicted. (Closed)

Created:
7 years, 7 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug when optimized code map is evicted. This makes sure that both, the shared function info and it's optimized code map get revisited when the code map is evicted from the flusher. R=hpayer@chromium.org TEST=mjsunit/debug-set-variable-value Committed: https://crrev.com/316ff3d8fc4f635ab04a053c7c6cf36f16f6c59c Cr-Commit-Position: refs/heads/master@{#29387}

Patch Set 1 #

Patch Set 2 : Resurrect ancient CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/heap/mark-compact.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
Michael Starzinger
7 years, 7 months ago (2013-05-16 09:57:44 UTC) #1
Hannes Payer (out of office)
lgtm
7 years, 7 months ago (2013-05-16 10:51:28 UTC) #2
Michael Starzinger
I am resurrecting this ancient fix (without the flag enabling). I assume a review from ...
5 years, 5 months ago (2015-06-30 15:12:32 UTC) #3
Hannes Payer (out of office)
still counts, ancient LGTM
5 years, 5 months ago (2015-06-30 15:59:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/14703009/4001
5 years, 5 months ago (2015-06-30 16:42:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:4001)
5 years, 5 months ago (2015-06-30 16:47:10 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 16:47:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/316ff3d8fc4f635ab04a053c7c6cf36f16f6c59c
Cr-Commit-Position: refs/heads/master@{#29387}

Powered by Google App Engine
This is Rietveld 408576698